Skip to content

HADOOP-17753. Keep restrict-imports-enforcer-rule for Guava Lists in top level hadoop-main pom#3087

Merged
tasanuma merged 1 commit intoapache:trunkfrom
virajjasani:HADOOP-17753-trunk
Jun 11, 2021
Merged

HADOOP-17753. Keep restrict-imports-enforcer-rule for Guava Lists in top level hadoop-main pom#3087
tasanuma merged 1 commit intoapache:trunkfrom
virajjasani:HADOOP-17753-trunk

Conversation

@virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Jun 9, 2021

No description provided.

@virajjasani virajjasani force-pushed the HADOOP-17753-trunk branch from 864dc42 to 89e961b Compare June 9, 2021 07:53
@virajjasani
Copy link
Contributor Author

virajjasani commented Jun 9, 2021

FYI @tasanuma. Since individual sub-modules are taken care of, this is for keeping enforcer rule at top level pom.
Local build looks good, let's see if we can get full QA result (unless build is aborted after 20 hr).
Thanks

@tasanuma tasanuma self-requested a review June 9, 2021 16:03
@tasanuma
Copy link
Member

tasanuma commented Jun 10, 2021

+1, pending QA.

@tasanuma
Copy link
Member

tasanuma commented Jun 10, 2021

QA had run over 20h and failed due to timeout. I created HADOOP-17756 to suggest extending the timeout.

@virajjasani
Copy link
Contributor Author

virajjasani commented Jun 10, 2021

Sure, Thanks. Exactly, this timeout keeps happening quite often. I was surprised to see full QA getting completed in 17+ hr in the first run on #3049 :)

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 10, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 13m 0s Maven dependency ordering for branch
+1 💚 mvninstall 20m 17s trunk passed
+1 💚 compile 20m 48s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 18m 12s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 3m 45s trunk passed
+1 💚 mvnsite 24m 18s trunk passed
+1 💚 javadoc 7m 31s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 7m 32s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 0m 27s branch/hadoop-cloud-storage-project/hadoop-cloud-storage no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 44m 46s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 41s Maven dependency ordering for patch
+1 💚 mvninstall 36m 23s the patch passed
+1 💚 compile 20m 38s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 20m 38s the patch passed
+1 💚 compile 18m 19s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 18m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 43s the patch passed
+1 💚 mvnsite 20m 18s the patch passed
+1 💚 xml 0m 25s The patch has no ill-formed XML file.
+1 💚 javadoc 7m 30s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 7m 41s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 0m 28s hadoop-cloud-storage-project/hadoop-cloud-storage has no data from spotbugs
+1 💚 shadedclient 44m 48s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 771m 14s root in the patch passed.
+1 💚 asflicense 1m 42s The patch does not generate ASF License warnings.
1174m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3087/5/artifact/out/Dockerfile
GITHUB PR #3087
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux 054b60f681cc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 89e961b
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3087/5/testReport/
Max. process+thread count 3662 (vs. ulimit of 5500)
modules C: hadoop-maven-plugins hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-tools/hadoop-distcp hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-workload hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-cloud-storage-project/hadoop-cos hadoop-cloud-storage-project/hadoop-huaweicloud hadoop-cloud-storage-project/hadoop-cloud-storage . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3087/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma
tasanuma approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow QA ran again, and it finished within 20 hours. The result looks good. +1.

@tasanuma tasanuma merged commit 4ef27a5 into apache:trunk Jun 11, 2021
@tasanuma
Copy link
Member

tasanuma commented Jun 11, 2021

Merged. Thanks for all your work, @virajjasani!

@virajjasani
Copy link
Contributor Author

virajjasani commented Jun 11, 2021

Thanks @tasanuma. I triggered 5 builds and fortunately 1 of them finished on time.

@virajjasani virajjasani deleted the HADOOP-17753-trunk branch June 15, 2021 07:12
@virajjasani virajjasani mentioned this pull request Oct 5, 2021
Merged
1 task
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@virajjasani
HADOOP-17753. Keep restrict-imports-enforcer-rule for Guava Lists in …
0499070 
…top level hadoop-main pom (apache#3087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tasanuma tasanuma tasanuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@virajjasani @tasanuma @hadoop-yetus